Improvements and refactoring of help system. #10280
Conversation
[ci skip-rust-tests]
| deprecation_version: Optional[str] | ||
| details: Optional[str] | ||
|
|
||
|
|
||
| # TODO: Get rid of this? The parser should be able to lazily track. | ||
| class OptionTracker: |
There was a problem hiding this comment.
I've never 100% understood this class, because I thought that the RankedValue container would be able to record where things had come from. But have never looked deeply.
There was a problem hiding this comment.
The RankedValue is just a single value attached to a Rank, it doesn't know about any other values.
There was a problem hiding this comment.
But there's probably some simplification we can do. E.g., the RankedValue can carry the "details" information (e.g., which config file a CONFIG-level value came from)
There was a problem hiding this comment.
It is, but it is inside an OptionValueContainer, which does have all of them, I thought? EDIT: But looking at it now, it's just a dict. Ok.
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
| deprecation_version: Optional[str] | ||
| details: Optional[str] | ||
|
|
||
|
|
||
| # TODO: Get rid of this? The parser should be able to lazily track. | ||
| class OptionTracker: |
There was a problem hiding this comment.
I've never 100% understood this class, because I thought that the RankedValue container would be able to record where things had come from. But have never looked deeply.
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Previously the HelpFormatter, HelpPrinter and HelpInfoExtracter were rather
entangled. This change:
instance of a new AllHelpInfo class, containing all help information,
including scope descriptions. The HelpPrinter/HelpFormatter operate
exclusively on this data. They no longer need access to an Options instance,
let alone a HelpInfoExtractor.
[ci skip-rust-tests]