Use with_workunit everywhere #10300
Merged
Use with_workunit everywhere #10300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jul 9, 2020
Comment on lines
283
to
288
| if let Some(workunit_state) = workunit_store::get_workunit_state() { | ||
| workunit_state.store.complete_workunit(span_id); | ||
| let store = workunit_state.store; | ||
| with_workunit(store, workunit_name, metadata, result_future, |_, md| md).await | ||
| } else { | ||
| result_future.await | ||
| } |
There was a problem hiding this comment.
In a followup, it might be useful to expose with_workunit as a static method or a macro that would do the equivalent of these 6 lines in one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes all call sites that were previously using the public
start_workunit/complete_workunitmethod pair to use thewith_workunitmethod, so that the former two methods can be made private.