refactor execution strategy options into separate struct #10304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The large number of execution strategy-related options passed into the engine's
Core::new
function is unwieldy. Adding a new option is a chore.Solution
Introduce
ExecutionStrategyOptions
struct and aPyExecutionStrategyOptions
wrapper. Use both.Result
The execution strategy-related options are now grouped into a single
ExecutionStrategyOptions
that can be passed around. It is clear where to add new execution strategy-related options.Implements #10273