Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove polling remote execution client #10306

Merged
merged 4 commits into from Jul 10, 2020
Merged

remove polling remote execution client #10306

merged 4 commits into from Jul 10, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 9, 2020

Problem

As described in #10270, we should remove the "polling" remote execution client because it has been superseded by the "streaming" remote execution client.

Solution

Remove the polling remote execution client.

Result

It is gone.

Implements #10270

stuhood
stuhood approved these changes Jul 9, 2020
View reviewed changes
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As mentioned, this should also deprecate the option and indicate that it's a noop.

@tdyas
Copy link
Contributor Author

tdyas commented Jul 9, 2020

@stuhood: What is the appropriate removal_version in this case?

@Eric-Arellano
Copy link
Contributor

2.1.0.dev0

@tdyas
Copy link
Contributor Author

tdyas commented Jul 10, 2020 •
edited

src/python/pants/backend/python/rules/pytest_runner_integration_test.py failed in CI but passes locally:

The file /tmp/tmp6bnykkxl/cp27-cp27mu/pathlib2-2.3.5-py2.py3-none-any.whl exists. (i)gnore, (w)ipe, (b)ackup, (a)abort

https://travis-ci.com/github/pantsbuild/pants/jobs/359534590#L1795

I have to rebase any way. Hopefully works with the rebase.

@tdyas tdyas force-pushed the remove_polling_remoting_client branch from 07cba00 to 6fdde7f Compare July 10, 2020 17:57
@stuhood stuhood merged commit ab07056 into pantsbuild:master Jul 10, 2020
@tdyas tdyas mentioned this pull request Sep 9, 2020
Merged
@stuhood stuhood mentioned this pull request Dec 28, 2020
Closed
@Eric-Arellano Eric-Arellano mentioned this pull request Feb 23, 2021
Merged
Eric-Arellano added a commit that referenced this pull request Feb 23, 2021
@Eric-Arellano
Remove unused process_execution::ExecutionStats (#11589)
ddc75f4 
This has not been used since removing the "polling" remote execution implementation in #10306. We are still interested in metrics for remote execution, but we can add this back in a way that makes sense for the streaming implementation once we are ready to do so.

[ci skip-build-wheels]
@tdyas tdyas deleted the remove_polling_remoting_client branch February 20, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tdyas @Eric-Arellano @stuhood