Use generated subtargets internally #10312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
We can delete it very soon, but not yet # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
Merged
Eric-Arellano
added a commit
that referenced
this pull request
Jul 11, 2020
This is only being used in one test now to determine a skip condition, and that skip condition is unnecessary. While this is generally useful code, we're not using it anymore (in favor of `packaging.Version`) and this causes #10312 because there is no owner in the `pantsbuild.pants` dist for the generated subtarget `base:revision.py`. [ci skip-rust-tests]
…ed-subtargets [ci skip-rust-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without generated subtargets, these changes would result in target-level cycles. But file-level dependencies means that we have no cycles.
[ci skip-rust-tests]