Fix awslambda configuration of Pex. #10323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an upgrade of Pex to support resolution of `--platform` arguments to matching local interpreters, awslambda now supports building sdists when possible. Additionally, awslambda now allows for AMI-specific non-manylinux wheels if needed. Fixes pantsbuild#10286. [ci skip-rust-tests]
jsirois
commented
Jul 11, 2020
| "--manylinux=manylinux2014", | ||
| # When we're executing Pex on Linux, allow a local interpreter to be resolved if | ||
| # available and matching the AMI platform. | ||
| "--resolve-local-platforms", |
There was a problem hiding this comment.
We may want to enable this by default for all of our Pex requests, but I want to keep this scoped.
Eric-Arellano
approved these changes
Jul 11, 2020
benjyw
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an upgrade of Pex to support resolution of
--platformargumentsto matching local interpreters, awslambda now supports building sdists
when possible. Additionally, awslambda now allows for AMI-specific
non-manylinux wheels if needed.
Fixes #10286.
[ci skip-rust-tests]