Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop differentiating between constructors and types in FFI #10327

Merged
merged 1 commit into from Jul 11, 2020
Merged

Stop differentiating between constructors and types in FFI #10327

merged 1 commit into from Jul 11, 2020

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Jul 11, 2020

Problem

Post cpython crate, there is no longer a need to differentiate constructors from types, as types are callable as well.

Solution

Remove construct_ functions on the Types struct.

@stuhood stuhood force-pushed the stuhood/stop-differentiating-between-constructors-and-types branch from dff4897 to 459c304 Compare July 11, 2020 05:56
Eric-Arellano
Eric-Arellano approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

illicitonion
illicitonion approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah! 🎉

@stuhood stuhood merged commit 62b2bbf into pantsbuild:master Jul 11, 2020
@stuhood stuhood deleted the stuhood/stop-differentiating-between-constructors-and-types branch July 11, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@gshuflin gshuflin Awaiting requested review from gshuflin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuhood @illicitonion @Eric-Arellano