Modernize virtualenv. #10330
Merged
Modernize virtualenv. #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #8951. |
|
Discovered bugs in virtualenv 16.6.2 wrt the |
|
I'll update this to leave a comment about why we can't do this .... but, since this script is for devs can't we just trap an error and ask devs to get their system un-borked? |
We do this by creating a virtualenv pex at the desired version and using that. To do so efficiently, downloading and caching of a pex tool is also factored up to build-support/common.py. # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
jsirois
force-pushed
the
virtualenv/modernize
branch
from
657879d
to
16e0498
Compare
|
Alright, PTAL - now using the latest virtualenv via pex. |
jsirois
changed the title
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jul 13, 2020
This reverts commit f583d18. [ci skip-rust-tests]
jsirois
added a commit
that referenced
this pull request
Jul 14, 2020
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Jul 15, 2020
…ntsbuild#10343) * Revert "Fix `run_virtualenv` to target the current `$PY`. (pantsbuild#10331)" This reverts commit 206b316. * Revert "Modernize virtualenv. (pantsbuild#10330)" This reverts commit f583d18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by creating a virtualenv pex at the desired version and
using that. To do so efficiently, downloading and caching of a pex
tool is also factored up to build-support/common.py.
[ci skip-rust-tests]