New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make help-all dump a JSON blob containing all help info. #10336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust-tests]
gshuflin
approved these changes
Jul 13, 2020
Eric-Arellano
approved these changes
Jul 13, 2020
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it dumped it in human-readable form, but that seems intrinsically unreadable.
That much data exists to be grepped over, so might as well make it JSON, and allow it
to be jq'd too.
Note: Removes the
--help-all
flag, as that might imply that it can act as a modifier, e.g., that./pants test --help-all
would show you "all the test help", whatever that might mean.We want to gently emphasize that "all means all". Of course you can still do
./pants help-all test
, so this is just a small nudge. I'd rather not error in this case.Also adds support for
./pants version
to do the same thing as./pants --version
etc.[ci skip-rust-tests]