Pass context to all callbacks calls instead of just passing it in the last call. #10340

asherf · 2020-07-13T21:24:33Z

Problem

After #10034, the context kwarg is only passed to the callback in the last call (where finished=True)

Solution

Pass the context param on every call to the callback

Result

Handlers/callbacks don't have to wait for the last call in order to call the context APIs in order to dump digests (for example)

… last call.

…assing it in the last call. (pantsbuild#10340) ### Problem After pantsbuild#10034, the context kwarg is only passed to the callback in the last call (where finished=True) ### Solution Pass the context param on every call to the callback ### Result Handlers/callbacks don't have to wait for the last call in order to call the context APIs in order to dump digests (for example)

asherf added 2 commits July 13, 2020 14:22

Pass context to all callbacks calls instead of just passing it in the…

16df0ce

… last call.

Fix

dd99c01

asherf requested review from gshuflin, Eric-Arellano and stuhood July 13, 2020 22:37

gshuflin approved these changes Jul 13, 2020

View reviewed changes

stuhood merged commit 7d20655 into pantsbuild:master Jul 14, 2020

asherf deleted the spell branch July 14, 2020 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass context to all callbacks calls instead of just passing it in the last call. #10340

Pass context to all callbacks calls instead of just passing it in the last call. #10340

asherf commented Jul 13, 2020 •

edited by stuhood

Pass context to all callbacks calls instead of just passing it in the last call. #10340

Pass context to all callbacks calls instead of just passing it in the last call. #10340

Conversation

asherf commented Jul 13, 2020 • edited by stuhood

Problem

Solution

Result

asherf commented Jul 13, 2020 •

edited by stuhood