Add module to default rule names. #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust-tests]
stuhood
force-pushed
the
stuhood/module-in-rule-names
branch
from
801bcdb
to
6836f1e
Compare
Eric-Arellano
approved these changes
Jul 14, 2020
gshuflin
approved these changes
Jul 14, 2020
Eric-Arellano
pushed a commit
that referenced
this pull request
Jul 14, 2020
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Jul 15, 2020
### Problem See pantsbuild#10296. ### Result Fixes pantsbuild#10296. [ci skip-rust-tests]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Jul 15, 2020
pantsbuild#10341 and pantsbuild#10344 collided, and a test broke on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #10296.
Result
Fixes #10296.
[ci skip-rust-tests]