Add check for invalid start and end times for TimeSpan
#10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
reviewed
Jul 14, 2020
| let duration = match end.checked_sub(start) { | ||
| Some(d) => d, | ||
| None => { | ||
| log::warn!("Invalid TimeSpan - start: {:?}, end: {:?}", start, end); |
There was a problem hiding this comment.
If this is happening fairly often, we're not going to want to be logging warnings, probably. But it would also be good to track down which codepath is creating inverted ranges like this. So maybe drop to debug...?
It should also be easy to detect that this is happening due to zero-length workunits.
gshuflin
force-pushed
the
checked_time_subtract
branch
from
1781198
to
32e36b8
Compare
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Jul 15, 2020
### Problem We noticed a Rust panic that stemmed from trying to subtract a later`std::time::Duration` from an earlier one in some of the `concrete_time` code used in the workunit store. ### Solution Replace the panic-capable subtraction with a checked subtraction that will log a warning when this happens and create a duration of zero-length, rather than failing. Note that the bulk of this code was inadvertently merged along with ee0cba3 . This commit contains one minor fix that should've been included with the former code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We noticed a Rust panic that stemmed from trying to subtract a later
std::time::Durationfrom an earlier one in some of theconcrete_timecode used in the workunit store.Solution
Replace the panic-capable subtraction with a checked subtraction that will log a warning when this happens and create a duration of zero-length, rather than failing.