Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency inference handling of dependencies on self #10373

Merged
merged 1 commit into from Jul 15, 2020

Conversation

Eric-Arellano
Copy link
Contributor

Before:

▶ ./pants dependencies src/python/pants/util:util
3rdparty/python:ansicolors
3rdparty/python:dataclasses
3rdparty/python:typing-extensions
src/python/pants/util/contextutil.py
src/python/pants/util/dirutil.py
src/python/pants/util/meta.py
src/python/pants/util/osutil.py
src/python/pants/util/strutil.py
src/python/pants/util/tarutil.py

After:

▶ ./pants dependencies src/python/pants/util:util
3rdparty/python:ansicolors
3rdparty/python:dataclasses
3rdparty/python:typing-extensions

We always intended for this behavior, but this regressed once we added generated subtargets.

[ci skip-rust-tests]

Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deja vu?

@Eric-Arellano
Copy link
Contributor Author

Hehe. CI failure on the other one that a GitHub URL won't work. Restarting the build and pulling didn't help, so I figured I'd try this.

@Eric-Arellano Eric-Arellano merged commit e77d947 into pantsbuild:master Jul 15, 2020
@Eric-Arellano Eric-Arellano deleted the fix-self-references2 branch July 15, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants