Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoting: use debug level for RE client workunits saved from remote #10382

Merged
merged 2 commits into from Jul 16, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 16, 2020

Problem

A recent bug fix causes Pants to print out INFO level messages even if the parent is DEBUG level. This now causes the workunits generated from remote execution timings to print out and spam the console with lots of messages like these:

18:41:46.01 [INFO] Completed: remote execution worker output uploading
18:41:46.22 [INFO] Completed: remote execution action scheduling
18:41:46.22 [INFO] Completed: remote execution worker input fetching
18:41:46.22 [INFO] Completed: remote execution worker command executing
18:41:46.22 [INFO] Completed: remote execution worker output uploading
18:41:46.32 [INFO] Completed: remote execution action scheduling
18:41:46.32 [INFO] Completed: remote execution worker input fetching

Solution

Set the workunits to DEBUG level.

Result

Log should not be spammed.

@tdyas tdyas requested review from gshuflin and stuhood July 16, 2020 19:26
@stuhood stuhood merged commit a22e3ab into pantsbuild:master Jul 16, 2020
@tdyas tdyas deleted the fix_re_client_workunit_levels branch February 20, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants