Allow ignoring dependencies with !
#10385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust-tests]
Also, generify the code so that we stop assuming dep inference uses generated subtargets and stop assuming that dependency injection uses normal Addresess. This is how it's implemented now, but it does not need to be. For example, today we mentioned how Java may not always want to use generated subtargets. Either way, this results in simpler code with fewer special cases. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be silly to do
[':sibling', '!:sibling], but this is useful for when dependency inference results in a false positive.The user may either specify a normal address or they may specify a file, which will cause us to look for the owning target and to generate a subtarget. We validate that files have exactly one owner, like what we do with explicit file deps in general.
Every ignore must actually cause a dependency to be ignored; we do not allow unmatched ignores. This reduces the risk of users thinking something is being ignored when it's really not.
[ci skip-rust-tests]