Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't turn on branch coverage by default. #10386

Merged
merged 1 commit into from Jul 17, 2020
Merged

Don't turn on branch coverage by default. #10386

merged 1 commit into from Jul 17, 2020

Conversation

asherf
Copy link
Member

@asherf asherf commented Jul 16, 2020

Follow up on #10289 (comment)

@asherf asherf mentioned this pull request Jul 16, 2020
Merged
Eric-Arellano
Eric-Arellano approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@asherf
Copy link
Member Author

asherf commented Jul 16, 2020

had some leftovers from debugging this. cleaned up now.

@Eric-Arellano Eric-Arellano merged commit e2d786b into pantsbuild:master Jul 17, 2020
@asherf asherf deleted the spell branch July 17, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asherf @Eric-Arellano