New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A script to generate options reference pages for the docsite. #10387
Conversation
See the result on the live docsite: https://www.pantsbuild.org/v2.0/docs/ |
- Uses mustache templates (plus some light munging in python) to generate the content. - The script can sync the pages to the docsite, or just render them locally, for ease of iteration and debugging. Makes some small changes/refactors to the help info extracter, to support the markdown/HTML generation. Removes a docstring line in external_tool.py that contained < > characters that rendered as >/< in the markdown. [ci skip-rust-tests]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent!
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
So, readme's search is much, much better than our old search. But I still sortof wonder whether we should inline all related options into each goal's page so that you can truly see "all options that matter to |
I don't think so. Having related subsystems is already awesome. There isn't much benefit imo to inlining the related subsystem options, other than saving a click. The downsides are a) worse search, and b) much larger pages, which are less performant and imo a little overwhelming to look at. |
The benefit (afaict) is that when you want to figure out "how do I enable XML for the The same goes for the CLI I think ( One option would be to inline a super abbreviated version with links to the actual help pages maybe...
... where each related subsystem option was a link to the page. |
Going to merge this, as we can and will modify the page content in any number of followups... |
generate the content.
them locally, for ease of iteration and debugging.
Makes some small changes/refactors to the help info extracter,
to support the markdown/HTML generation.
Removes a docstring line in external_tool.py that contained
< > characters that rendered as >/< in the markdown.
[ci skip-rust-tests]