Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate target cycles when using dependency inference #10393

Merged
merged 3 commits into from Jul 17, 2020
Merged

Tolerate target cycles when using dependency inference #10393

merged 3 commits into from Jul 17, 2020

Commits on Jul 17, 2020

  1. Tolerate cycles between targets when using dependency inference 

    # Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
    @Eric-Arellano
    Eric-Arellano committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    20bae23 View commit details
    Browse the repository at this point in the history

  2. Add back cycles to Pants 

    We can now use our conditional `if TYPE_CHECKING` imports. We no longer have the problem that sometimes MyPy would fail to find the import; all dependencies are properly modeled :)

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
    @Eric-Arellano
    Eric-Arellano committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    13b5794 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:pantsbuild/pants into tolerate-cy… 

    …cles
    @Eric-Arellano
    Eric-Arellano committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ca63934 View commit details
    Browse the repository at this point in the history