Fix validation of dependencies ignores breaking with generated subtargets #10407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We eagerly validate that every
!
is used in thedependencies
field as a matter of good UX, because it's confusing how all the different pieces fit together.However, imagine this: you have a target that owns 5 files. You set on that target
!./bad.py
. However, only one of those 5 files actually usesbad.py
. This means that the 4 other generated subtargets would now all complain that the ignore!./bad.py
is unused.[ci skip-rust-tests]