Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused v1 sources. #10411

Merged
merged 1 commit into from Jul 21, 2020
Merged

Delete unused v1 sources. #10411

merged 1 commit into from Jul 21, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jul 21, 2020

Also, removes superfluous fingerprint=True option kwargs.

[ci skip-rust-tests]

@benjyw
Delete unused v1 sources.
5078e0f 
Also, removes superfluous fingerprint=True option kwargs.

[ci skip-rust-tests]
Eric-Arellano
Eric-Arellano approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 5078e0f on benjyw:option_fingerprint_arg into 22cc05f on pantsbuild:master.

@benjyw benjyw merged commit 2eb679a into pantsbuild:master Jul 21, 2020
@benjyw benjyw deleted the option_fingerprint_arg branch August 7, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjyw @coveralls @Eric-Arellano