Add support for bandit output file. #10412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/python/pants/backend/python/lint/bandit/rules_integration_test.py
Outdated
Show resolved
Hide resolved
Eric-Arellano
pushed a commit
that referenced
this pull request
Jul 22, 2020
|
Oops, I meant to merge this a few days ago. There have been some changes to the Plugin API the last week that conflict with this. I'm pushing a fix in a few moments and will merge when green. |
# Conflicts: # src/python/pants/backend/python/lint/bandit/rules.py # src/python/pants/backend/python/lint/bandit/rules_integration_test.py # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10371
Problem
CI Systems (among other things) can usually pick up output of linters and display them in a more use friendly way (similar idea to junitxml for tests)
Currently, there is no way to have bandit write the violations it detects to a file (passthru args won't work due to pants engine isolation requirements)
Solution
Add explicit support for the bandit --output paramter and extract the output and write it to the requested directory.