Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register any options as recursive. #10415

Merged
merged 2 commits into from Jul 21, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jul 21, 2020

This will remove the --level option from the
advanced options help of every single scope...

Note that this doesn't remove the recursive options
machinery - that is used under the covers to support
subsystems scoped to other subsystems, and we're
not yet sure what we want to do with those.

[ci skip-rust-tests]

This will remove the --level option from the
advanced options help of every single scope...

Note that this doesn't remove the recursive options
machinery - that is used under the covers to support
subsystems scoped to other subsystems, and we're
not yet sure what we want to do with those.

[ci skip-rust-tests]
@benjyw benjyw requested a review from stuhood July 21, 2020 17:34
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Note that this doesn't remove the recursive options
machinery

Is it possible to remove the kwarg, without removing the scope-specific portion of the implementation?

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. +1 to Stu's suggestion.

@coveralls
Copy link

coveralls commented Jul 21, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 7af045a on benjyw:no_recursive_options into 64bfcbb on pantsbuild:master.

@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Jul 21, 2020

Is it possible to remove the kwarg, without removing the scope-specific portion of the implementation?

That's a little more complicated - a bunch of tests rely on that to test the scoping behavior that we (may) still want to maintain
for scoped subsystems. So those tests would need to be rewritten. My main goal for now is to get the help looking sensible, and I don't want to remove the support for recursive options in the help system, because those would actually be potentially useful for scoped subsystems help...

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
@benjyw benjyw merged commit 0d04089 into pantsbuild:master Jul 21, 2020
@benjyw benjyw deleted the no_recursive_options branch July 21, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants