Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up remaining uses of testutil.subsystem.util and delete it. #10427

Merged
merged 1 commit into from Jul 22, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jul 22, 2020

Use v2 ways of getting subsystems instead.

In one case, modifies the is_python2 test to not
require a subsystem instance (of PythonSetup)
at all, since it really only needed it for the
compatibilities_or_constraints logic,
which is orthogonal to the is_python2 logic.

[ci skip-rust-tests]

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 84e0b11 on benjyw:cleanup_init_subsystem2 into e4b6476 on pantsbuild:master.

@benjyw benjyw merged commit aa95266 into pantsbuild:master Jul 22, 2020
@benjyw benjyw deleted the cleanup_init_subsystem2 branch July 22, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants