New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --print-exception-stacktrace
not invalidating pantsd
#10451
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #10035 for the explanation of when
fingerprint=True
vsdaemon=True
is relevant, but: afaict exceptions before the scheduler is created should always result in a full stacktrace, so it shouldn't be necessary to restartpantsd
(ie,daemon=True
) for this option.On the other hand, having this marked
fingerprint=False
means that we won't recreate theScheduler
if this value changes... and that is a bug, because theScheduler
does consume this option. So I think that you probably just want to mark thisfingerprint=True
(which should be equivalent to removing the argument).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. This morning I was having issues with
fingerprint=True
actually causing a change in behavior - it did change the behavior, but it looked like portions of the stacktrace were still being printed (less than normal). I didn't capture that output, sorry.I can't reproduce it though, so looks like this is working correctly now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be because I changed the wrong option. Oops.
This is the output I get when
fingerprint=True, daemon=False
. This was after running with--print-exception-stacktrace
already.If I have
daemon=True
, I get the expected result:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. It looks like that's because this is a sneaky global-mutable option on the
ExceptionSink
:pants/src/python/pants/init/logging.py
Lines 70 to 76 in 9ca7b52
daemon=True
for now?