Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize generated subtargets' interaction with SpecifiedSourceFiles #10454

Merged
merged 1 commit into from Jul 26, 2020

Conversation

Eric-Arellano
Copy link
Contributor

Benchmark runs ./pants --no-pantsd lint 'src/python/pants/util/*.py' 10 times without pantsd and with Process already cached.

Before:

            Mean        Std.Dev.    Min         Median      Max
real        2.697       0.034       2.652       2.706       2.752
user        2.354       0.025       2.317       2.361       2.392
sys         0.432       0.011       0.420       0.428       0.452

After:

            Mean        Std.Dev.    Min         Median      Max
real        2.605       0.018       2.588       2.599       2.648
user        2.259       0.015       2.243       2.253       2.296
sys         0.403       0.005       0.395       0.405       0.408

This means that we almost never use SpecifiedSourceFiles's logic. Almost always, SpecifiedSourceFiles is the same thing as AllSourceFiles. The only time that the two diverge is when file arguments cannot use generated subtargets because there are multiple owners of the file.

[ci skip-rust-tests]

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling b0021a1 on Eric-Arellano:specified-snapshots into 0a61cf8 on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit 1e27fb5 into pantsbuild:master Jul 26, 2020
@Eric-Arellano Eric-Arellano deleted the specified-snapshots branch July 26, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants