Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fromfile expansion to skip passthrough args. #10457

Merged
merged 1 commit into from Jul 27, 2020
Merged

Fix fromfile expansion to skip passthrough args. #10457

merged 1 commit into from Jul 27, 2020

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jul 27, 2020

We should perform no processing of args in passthrough position at all.

@jsirois
Fix fromfile expansion to skip passthrough args.
4fd556e 
We should perform no processing of args in passthrough position at all.
@jsirois
Copy link
Member Author

jsirois commented Jul 27, 2020

A case of this bug in the wild led to new tests that fail without the fix like so:

pants.option.errors.FromfileError: Failed to read passthru_listvalue in scope 'fromfile' from file jake: FileNotFoundError(2, 'No such file or directory')
pants.option.errors.FromfileError: Failed to read passthing in scope 'passconsumer' from file dont_fromfile_expand_me: FileNotFoundError(2, 'No such file or directory')

@jsirois jsirois requested a review from benjyw July 27, 2020 03:33
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 4fd556e on jsirois:Parser/fix_passthrough_fromfile into 9ca7b52 on pantsbuild:master.

benjyw
benjyw approved these changes Jul 27, 2020
View reviewed changes
Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes!

Eric-Arellano
Eric-Arellano approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jsirois jsirois merged commit 77368df into pantsbuild:master Jul 27, 2020
@jsirois jsirois deleted the Parser/fix_passthrough_fromfile branch July 27, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsirois @coveralls @benjyw @Eric-Arellano