Allow for more cyclic cases with file dependencies #10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
stuhood
changed the title
Eric-Arellano
approved these changes
Jul 27, 2020
| @@ -161,11 +161,31 @@ def _detect_cycles( | |||
| path_stack: OrderedSet[Address] = OrderedSet() | |||
| visited: Set[Address] = set() | |||
|
|
|||
| def maybe_report_cycle(address: Address) -> None: | |||
There was a problem hiding this comment.
Nit: report is a polite way of saying raise hehe. No need to change though.
|
Only test failure is a newly skipped test. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We'd like to allow cycles via file addresses, but not all cases are considered: see #10471.
Solution
Don't report a cycle if there is a file address anywhere in the cyclic portion.
Result
Fixes #10471. Performance is unchanged.
[ci skip-rust-tests]