Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test output. #10484

Merged
merged 2 commits into from Jul 28, 2020
Merged

Improve test output. #10484

merged 2 commits into from Jul 28, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jul 28, 2020

  • Adds a flag that allows you to select whether test
    stdout/stderr is displayed for all tests, failed tests
    or no tests. Defaults to only failed tests, which is the most
    useful setting. That way when running over many tests you
    can easily focus on just the failed ones, particularly in CI.

  • Shows the summary in all cases. Previously we omitted it
    when there's only one test target in play, but that's
    kinda weird and inconsistent.

[ci skip-rust]

[ci skip-build-wheels]

- Adds a flag that allows you to select whether test
  stdout/stderr is displayed for all tests, failed tests
  or no tests.  Defaults to failed tests, which is the most
  useful setting. That way when running over many tests you
  can easily focus on just the failed ones.

- Shows the summary in all cases. It's weird to have special-case
  different behavior when there's only one test target in play
  vs if there are two.

[ci skip-rust]

[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

src/python/pants/core/goals/test.py Outdated Show resolved Hide resolved
src/python/pants/core/goals/test.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 28, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling db6f4fd on benjyw:test_output into 2773086 on pantsbuild:master.

Also add color to the summary.

[ci skip-rust]

[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch with the color codes.

@benjyw benjyw merged commit 67cdeb3 into pantsbuild:master Jul 28, 2020
@benjyw benjyw deleted the test_output branch July 28, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants