Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for rule graph issues with each distinct backend #10519

Merged
merged 2 commits into from Jul 31, 2020

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Jul 31, 2020

We want to make sure that no matter what combination of backend packages you have loaded, Pants will not error due to issues with the rule graph.

Closes #10430.

[ci skip-rust]
[ci skip-build-wheels]

[ci skip-rust]
[ci skip-build-wheels]
We don't use it, so there's no reason to load it, now that we have this test.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very awesome. Thanks!

@Eric-Arellano Eric-Arellano merged commit 2b98738 into pantsbuild:master Jul 31, 2020
@Eric-Arellano Eric-Arellano deleted the backend-ambiguity branch July 31, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that every backend can be loaded without rule graph issues
2 participants