Allow protobuf_library targets to specify a python source root. #10549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If specified, the sources will be generated under this source root. This can allow users to sidestep issues around namespace packages and/or __init__.py files. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Aug 4, 2020
src/python/pants/backend/codegen/protobuf/python/additional_fields.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/codegen/protobuf/python/additional_fields.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/codegen/protobuf/python/rules_integration_test.py
Show resolved
Hide resolved
|
Added a test to assert that we can generate from a non-root source root (src/proto/protos/f.proto) to the root source root (protos/f_pb2.py). |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specified, the sources will be generated under this
source root. This can allow users to sidestep issues around
namespace packages and/or
__init__.pyfiles.E.g., if importing works correctly under src/python then
generating .py files under that root will allow them to be
imported, whereas generating them under src/protobuf
might require adding
__init__.pyfiles to get importsto work.
[ci skip-rust]
[ci skip-build-wheels]