Deprecate --option-name-check-distance
#10611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
approved these changes
Aug 15, 2020
Eric-Arellano
changed the title
--option-name-check-distance--option-name-check-distance
This makes it ever so slightly easier for users upgrading to 2.0. We still remove all functionality from the flag - it now no-ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, Pants suffers from options fatigue. It's sensible to always use a max edit distance of 2 for Levenshtein matching on bad option names - there isn't much utility to allowing users to configure something so granular.
This simplifies our code, reduces the # of options for users, and will allow us to change the algorithm if we ever want to.
[ci skip-rust]
[ci skip-build-wheels]