Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON coverage report #10625

Merged
merged 4 commits into from Aug 23, 2020
Merged

Conversation

asherf
Copy link
Member

@asherf asherf commented Aug 16, 2020

https://coverage.readthedocs.io/en/coverage-5.2.1/config.html#json

Problem

The ability to produce json formatted coverage reports was added to coverage.py a while ago, pants doesn't expose that ability.

Solution

Add json report type to the CoverageReportType enum

@coveralls
Copy link

coveralls commented Aug 16, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling f4bc8bf on asherf:misc into ff2bec3 on pantsbuild:master.

@Eric-Arellano
Copy link
Contributor

Cool. Are you planning on the change to Coverage being a separate PR? It'd probably be better to include in this PR so that the changelog is smaller for our users.

@asherf
Copy link
Member Author

asherf commented Aug 18, 2020

not planning to change any config in this repo.
Just wanted to expose that functionality since the underlying coverage.py supports it.
I need to add some tests now that the other PR is merged.
so I will be adding logic to existing integration test to cover this use case.

@asherf asherf force-pushed the misc branch 2 times, most recently from cd4d67b to cdcdaec Compare August 18, 2020 20:07
@asherf
Copy link
Member Author

asherf commented Aug 22, 2020

fixed issue calling coverage report with the correct params.
2830210
this should be g2g

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Asher!

@Eric-Arellano Eric-Arellano merged commit 677ab8f into pantsbuild:master Aug 23, 2020
@asherf asherf deleted the misc branch August 23, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants