Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring in the graph crate #10637

Merged
merged 1 commit into from Aug 18, 2020
Merged

Some refactoring in the graph crate #10637

merged 1 commit into from Aug 18, 2020

Conversation

gshuflin
Copy link
Contributor

This commit consists of some minor refactoring in the graph crate, meant to improve readability

  • use more concise Rust syntactic features in a few locations
  • rename get() to the more descriptive get_node_output()
  • rename run() to the more descriptive spawn_node_execution()
  • has_uncacheable_deps() only needs to be pub(crate) not pub

@gshuflin
Refactoring in graph
def84cb 
Remove pollers

* make some code more concise
* rename get() -> get_node_output()
* rename run() -> spawn_node_execution()
* has_uncacheable_deps() only needs to be pub(crate)

[ci skip-build-wheels]
Eric-Arellano
Eric-Arellano approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Greg! Good changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling def84cb on gshuflin:some_graph_refactors into f808253 on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit 7cacdd2 into pantsbuild:master Aug 18, 2020
@gshuflin gshuflin deleted the some_graph_refactors branch August 18, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@illicitonion illicitonion Awaiting requested review from illicitonion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gshuflin @coveralls @Eric-Arellano