Rename TestBase.request_single_product to TestBase.request_product
#10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels] [ci skip-rust]
Eric-Arellano
commented
Aug 23, 2020
|
|
||
| def build_path(self, relpath: str) -> str: |
Comment on lines
-84
to
-85
| _build_graph = None | ||
| _address_mapper = None |
| else: | ||
| return os.path.join(relpath, "BUILD") | ||
|
|
||
| def create_dir(self, relpath: str) -> str: |
There was a problem hiding this comment.
Still here, just moved lower.
| self.invalidate_for(relpath) | ||
| return path | ||
|
|
||
| def create_workdir_dir(self, relpath: str) -> str: |
There was a problem hiding this comment.
Deleted. It was unused.
| @@ -129,18 +102,17 @@ def invalidate_for(self, *relpaths): | |||
| files = {f for relpath in relpaths for f in recursive_dirname(relpath)} | |||
| return self._scheduler.invalidate_files(files) | |||
|
|
|||
| def create_link(self, relsrc: str, reldst: str) -> None: | |||
There was a problem hiding this comment.
Deleted. Unused.
| @@ -168,29 +140,18 @@ def create_files(self, path: str, files: Iterable[str]) -> None: | |||
| for f in files: | |||
| self.create_file(os.path.join(path, f), contents=f) | |||
|
|
|||
| def create_workdir_file(self, relpath: str, contents: str = "", mode: str = "w") -> str: | |||
There was a problem hiding this comment.
Deleted. Unused.
| } | ||
|
|
||
| self._build_configuration = self.build_config() | ||
|
|
||
| def buildroot_files(self, relpath: Optional[str] = None) -> Set[str]: |
There was a problem hiding this comment.
Deleted. Unused.
| return cast(SchedulerSession, self._scheduler) | ||
|
|
||
| def post_scheduler_init(self): |
There was a problem hiding this comment.
Deleted. Unused.
| @@ -396,17 +319,6 @@ def assertDoesNotRaise(self, exc_class: Type[BaseException] = Exception): | |||
| except exc_class as e: | |||
| raise AssertionError(f"section should not have raised, but did: {e}") from e | |||
|
|
|||
| @staticmethod | |||
| def get_bootstrap_options(cli_options=()): | |||
There was a problem hiding this comment.
Inlined to the one call site we had.
benjyw
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we used "single" to distinguish from the batched
scheduler.product_request. However, we no longer use the synchronous API outside of tests and special startup code - end users should never seescheduler.product_request.Further, we don't care that
TestBase.request_product()is only one-product-at-a-time. That's fine for tests, where we don't care about the speed of batching. We care more about readability with tests.[ci skip-build-wheels]
[ci skip-rust]