Rename run_rule to run_rule_with_mocks
#10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
requested review from
stuhood,
benjyw,
gshuflin and
cosmicexplorer
|
Open to better names :)
This means that we will have much more cache invalidation for our own tests than we'd like. But I'm optimizing here for a good public API as documented by https://www.pantsbuild.org/v2.0/docs/rules-api-testing. |
benjyw
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_rule()sounds far too similar toRuleRunner(). See https://www.pantsbuild.org/v2.0/docs/rules-api-testing for how these things are different.run_rule_with_mocksbetter expresses what this approach is useful for: running a@rulewith controlled (~mocked) input, including mockedawait Gets.We move this function to
testutil/rule_runner.pyfor easier imports, as it does fit into the overall theme of "running rules".[ci skip-rust]
[ci skip-build-wheels]