Add the ability to capture all known scope options in run tracker. #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshuflin
reviewed
Sep 14, 2020
src/python/pants/goal/run_tracker.py
Outdated
| @@ -134,7 +134,7 @@ def register_options(cls, register): | |||
| help="Option scopes to record in stats on run completion. " | |||
| "Options may be selected by joining the scope and the option with a ^ character, " | |||
| "i.e. to get option `pantsd` in the GLOBAL scope, you'd pass " | |||
| "`GLOBAL^pantsd`", | |||
| "`GLOBAL^pantsd`, add a '*' to the list to capture all known scopes", | |||
There was a problem hiding this comment.
Nit: I'd make this a separate sentence. "GLOBAL^pantsd. Add a '*' to the list to capture all known scopes",
gshuflin
approved these changes
Sep 14, 2020
Eric-Arellano
approved these changes
Sep 15, 2020
Eric-Arellano
pushed a commit
that referenced
this pull request
Sep 24, 2020
the global scope "key" is an empty string, so fix that in the recorded options dict Follow up for: #10778 <img width="703" alt="Screen Shot 2020-09-17 at 1 15 24 PM" src="https://user-images.githubusercontent.com/1268088/93523412-da310180-f8e7-11ea-8f93-f4540ecf4c30.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to tell RunTracker to capture options in all known scopes.
Solution
Allow adding a "*" element to the list of scope thus telling run tracker to capture options from all known scopes.
Result
All options can be available to code consuming data from run tracker.