Upgrade to Pex 2.1.16. #10782
Upgrade to Pex 2.1.16. #10782
Conversation
| default_version = "v2.1.14" | ||
| default_known_versions = [ | ||
| f"v2.1.14|{plat}|12937da9ad5ad2c60564aa35cb4b3992ba3cc5ef7efedd44159332873da6fe46|2637138" | ||
| for plat in ["darwin", "linux "] |
There was a problem hiding this comment.
I just noticed the trailing space in "linux " ... that can't be right.
There was a problem hiding this comment.
The space is stripped as a convenience for readability in pants.toml. It doesn't matter, but agreed that's confusing.
There was a problem hiding this comment.
So I can remove it? I find we don't use the value in our tomls?:
$ git grep linux *.toml
$
Does it somehow show up in users' tomls?!
There was a problem hiding this comment.
... and why no space in "darwin" - there are a million questions this raises.
There was a problem hiding this comment.
Yep, you can remove it. It was a typo, but a typo that doesn't break anything.
What I mean with toml files is that users are able to set values like --protoc-known-versions. From the help message:
Values are space-stripped, so pipes can be indented for readability if necessary.
There was a problem hiding this comment.
Gotcha - thanks. I may save that for follow up.
There was a problem hiding this comment.
Actually, this needs to follow #10779 so I'll fix it in the PR as soon as that PR lands.
Besides general improvements this picks up a fix for PEP-420 implicit (namespace) packages in loose sources and resources added via `-D` and `-R` which allows us to return to producing `zip_safe` PEXes by default (see: pantsbuild#10608 which this change reverts). 2.1.16 release notes here: https://github.com/pantsbuild/pex/blob/master/CHANGES.rst#2116 2.1.15 release notes here: https://github.com/pantsbuild/pex/blob/master/CHANGES.rst#2115 [ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
force-pushed
the
pex/2.1.16/upgrade
branch
from
c3c0979
to
b9b276f
Compare
|
Rebased against now-merged ##10779 - this should go green in which case I'll submit. |
Besides general improvements this picks up a fix for PEP-420 implicit
(namespace) packages in loose sources and resources added via
-Dand-Rwhich allows us to return to producingzip_safePEXes by default(see: #10608 which this change reverts).
2.1.16 release notes here:
https://github.com/pantsbuild/pex/blob/master/CHANGES.rst#2116
2.1.15 release notes here:
https://github.com/pantsbuild/pex/blob/master/CHANGES.rst#2115
[ci skip-rust]
[ci skip-build-wheels]