Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pantsd when piping output for internal script #10810

Merged
merged 2 commits into from Sep 18, 2020
Merged

Disable pantsd when piping output for internal script #10810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31758f7
Disable pantsd when piping output.
asherf Sep 17, 2020
3862d2b
Update generate_lockfile.sh
asherf Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-support/bin/generate_lockfile.sh
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@ constraints_file=3rdparty/python/constraints.txt

VENV=$(mktemp -d -t pants_lockfile_venv.XXXXX)
python3 -m venv "${VENV}"
"${VENV}/bin/pip" install -r <(./pants --tag=-lockfile_ignore dependencies --type=3rdparty ::)
# Disabled pantsd see https://github.com/pantsbuild/pants/issues/10438
"${VENV}/bin/pip" install -r <(./pants --no-pantsd --tag=-lockfile_ignore dependencies --type=3rdparty ::)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference #10438 in a TODO here.

echo "# Generated by build-support/bin/generate_lockfile.sh on $(date)" > "${constraints_file}"
"${VENV}/bin/pip" freeze --all >> "${constraints_file}"