work around trailing slash issue with protobuf codegen #10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Sep 23, 2020
tdyas
changed the title
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Sep 24, 2020
) ### Problem See pantsbuild#10802 for an issue with protobuf generation and remote execution. As it turns out, sending the output directory as `out/` with a trailing slash caused BuildBarn to generate a Directory proto with a empty directory name in it. The trailing slash is forbidden by the REAPI spec in any event: https://github.com/bazelbuild/remote-apis/blob/f54876595da9f2c2d66c98c318d00b60fd64900b/build/bazel/remote/execution/v2/remote_execution.proto#L507-L508 ### Solution This solution is just a short-term work around. A better fix would provide better validation of REAPI requests. ### Result The example-python repository is buildable in remote execution with BuildBarn. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #10802 for an issue with protobuf generation and remote execution. As it turns out, sending the output directory as
out/with a trailing slash caused BuildBarn to generate a Directory proto with a empty directory name in it.The trailing slash is forbidden by the REAPI spec in any event: https://github.com/bazelbuild/remote-apis/blob/f54876595da9f2c2d66c98c318d00b60fd64900b/build/bazel/remote/execution/v2/remote_execution.proto#L507-L508
Solution
This solution is just a short-term work around. A better fix would provide better validation of REAPI requests.
Result
The example-python repository is buildable in remote execution with BuildBarn.