Add RuleRunner.set_options()
#10859
Merged
Add RuleRunner.set_options()
#10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
set-options
branch
from
778fdf8
to
64fbf16
Compare
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Sep 25, 2020
As introduced in #10827, this is a more correct modeling for reading the environment variables. It will result in less invalidation of Pantsd. Likewise, we can extend our `rule_runner.set_options()` method introduced in #10859 to simplify how tests change the `PantsEnvironment`. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #10827, options are now set up through a new
SessionValuesmechanism. This means that our tests should no longer be passingOptionsBootstrapperas aParamanymore.Instead, we must mutate the
SchedulerSessionwhen setting options. We surface a new entry-point.set_options(), which will change the options for the life of theRuleRunnerinstance.RuleRunneralready was high on mutation, such asrule_runner.create_file()mutating the build root. This is why we encourage using Pytest fixtures to ensure each test is a new instance.A followup will move
PantsEnvironmentto aSessionValue.[ci skip-rust]
[ci skip-build-wheels]