Add await Get(Addresses, UnparsedAddressInputs)
#10913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
requested review from
tdyas,
cosmicexplorer,
gshuflin and
benjyw
Eric-Arellano
commented
Oct 6, 2020
benjyw
approved these changes
Oct 6, 2020
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are now ~dozen instances where we allow the user to specify an address somewhere other than the
dependenciesfield, such as options like--protoc-runtime-targets.We had lots of duplication for parsing these raw string values. Likewise, every single implementation failed to handle subprojects correctly.
Solution
Factor up a new
UnparsedAddressInputstype. This stores strings, rather thanAddressInput, so that we can make sure we consider subprojects correctly without callers needing to know this exists.This is a much simpler implementation than the dependencies field, e.g. not allowing for
!and!!ignores.[ci skip-rust]
[ci skip-build-wheels]