Use TransitiveTargetsRequest as input for resolving TransitiveTargets
#10915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Oct 6, 2020
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
transitive-targets-request
branch
from
e3fddac
to
40c8fc0
Compare
These behave almost the same, but don't work with dep inference [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
commented
Oct 7, 2020
Comment on lines
+357
to
+359
| direct_dependencies_addresses_per_tgt = await MultiGet( | ||
| Get(Addresses, DependenciesRequestLite(tgt.get(Dependencies))) for tgt in queued | ||
| ) |
There was a problem hiding this comment.
This fails if we change it to Get(Targets).
Comment on lines
+387
to
+390
| wrapped_transitive_excludes = await MultiGet( | ||
| Get( | ||
| WrappedTarget, AddressInput, AddressInput.parse(addr, relative_to=tgt.address.spec_path) | ||
| ) |
There was a problem hiding this comment.
We can't use Get(Targets, UnparsedAddressInputs).
Comment on lines
+908
to
+910
| subtargets = await Get( | ||
| Subtargets, Address, request.field.address.maybe_convert_to_base_target() | ||
| ) |
There was a problem hiding this comment.
Normally we only do this if inference isn't at play. Because we never use inference here, we always perform this step.
gshuflin
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As explained in #10888, we are not properly handling "special-cased" dependencies-like fields, such as
python_tests'sruntime_package_dependenciesfield.We need those fields' dependencies to show up in project introspection, such as
./pants dependencies, but not in other contexts like when resolving the transitive targets to determine what source files are used by Pytest.That is, we need to be able to parametrize
await Get(TransitiveTargets)so call sites can determine the behavior they want.Solution
Add
TransitiveTargetsRequest, which will allow us to add new fields to it to change its behavior. This mirrors how we haveDependenciesRequestfor direct deps.Note that this means you can no longer request
TransitiveTargetsas a parameter to your rule and have it be evaluated automatically by looking at theSpecs. You must now requestAddresses, and then useawait Get. There's an argument for this being a good thing. It's a bit confusing (imo) how some types likeAddressescan be in a rule signature and will be evaluated by using the Specs. This means that you can now only do that withAddressesandTargets, but notTransitiveTargets.To work around #10917, we add a
DependenciesRequestLiteandTransitiveTargetsLitefor use with codegen. These behave almost the same, but don't work with dep inference.[ci skip-rust]
[ci skip-build-wheels]