Correctly terminate child processes to fix ./pants repl bug #10930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently if a user hits Ctrl-C while at the Python REPL spawned by
./pants repl
on Python targets, pants will quit but the repl process will remain running, listening to stdin on the terminal pants just exited in some kind of indeterminate state, which screws up further input into that terminal.Solution
The problem was that when pants receives a SIGINT signal from the user hitting Ctrl-C, it sends SIGINT to all child processes. However, SIGINT does not actually terminate a Python REPL - it prints the text "KeyboardInterrupt" and continues to run. In order to actually shut down the Python process (or any other process that has similar behavior with respect to SIGINT), we need to send the SIGTERM signal instead.
Result
Hitting Ctrl-C when at the Python REPL now correctly terminates all of pants, pantsd, and the underlying Python REPL process.