Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC Python code generation #10937

Merged
merged 1 commit into from Oct 9, 2020
Merged

Conversation

Eric-Arellano
Copy link
Contributor

Users activate this on a per-target basis:

# BUILD
protobuf_library(grpc=True)

This signals that all relevant code generators should use the gRPC plugin. For now, that is only Python. But when adding other languages like Java, it will need to respect this flag.

Closes #10497.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huzzah!

@Eric-Arellano Eric-Arellano merged commit cd22820 into pantsbuild:master Oct 9, 2020
@Eric-Arellano Eric-Arellano deleted the grpc branch October 9, 2020 20:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling b7d9acf on Eric-Arellano:grpc into de974d2 on pantsbuild:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gRPC and MyPy support to Python Protobuf
4 participants