Fix config validation not erroring on global options in wrong scope #10950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Oct 12, 2020
There was a problem hiding this comment.
I plan to cherry-pick to 1.30.2.
This means that an option belonging to [cache] will now error if it's in [cache.java]. @benjyw is that correct behavior?
No, that is incorrect behavior. |
|
Hm, then this PR is incorrect. Until we remove the "enclosing scope" logic, we should probably special case the validation logic to ignore GLOBAL as a valid enclosing scope in this particular context. I'll revisit. |
benjyw
approved these changes
Oct 13, 2020
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Oct 13, 2020
…antsbuild#10950) This used to not complain: ```toml [source] backend_packages = ["pants.backend.python"] ``` Closes pantsbuild#3713. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to not complain:
Closes #3713.
[ci skip-rust]
[ci skip-build-wheels]