Restore several removed targets and fields to help with upgrading #10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asherf
approved these changes
Oct 15, 2020
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
asherf
reviewed
Oct 15, 2020
| @@ -104,6 +108,14 @@ class BundlesField(SequenceField): | |||
| expected_element_type = Bundle | |||
| expected_type_description = "an iterable of `bundle` objects" | |||
|
|
|||
| @classmethod | |||
| def compute_value(cls, raw_value: Optional[Iterable[Bundle]], *, address: Address) -> None: | |||
| try: | |||
There was a problem hiding this comment.
Oh, good point. This code is only being added to 2.0.0, though, in a hackily named deprecated_v1_target_types.py file, so I'm not gonna worry about it.
Good to know for the future, though.
benjyw
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10963.
Even though these restored types no-op, a user pointed out that this will help with upgrading to 2.0. You can use
pants_ignore_warningsto ignore these no-ops until you're ready to deal with them. We had no good reason to eagerly error, other than oversight.