Fix ./pants repl to use global constrains when no targets specified
#10991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
gshuflin
approved these changes
Oct 19, 2020
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Oct 19, 2020
…pantsbuild#10991) As pointed out in pantsbuild#10987, it's reasonable to expect that setting `--python-setup-interpreter-constraints` should influence the interpreter used when running `./pants repl` with no files/targets. Without this, we use empty constraints, and could end up choosing any interpreter, which is a bug. Result: ``` ▶ ./pants --python-setup-interpreter-constraints='["CPython==2.7.*"]' --python-setup-resolve-all-constraints=never repl 13:55:22.01 [INFO] Completed: Building requirements.pex Python 2.7.16 (default, Jun 5 2020, 22:59:21) ``` This also fixes an invalid type for `--ipython-ignore-cwd`. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #10987, it's reasonable to expect that setting
--python-setup-interpreter-constraintsshould influence the interpreter used when running./pants replwith no files/targets. Without this, we use empty constraints, and could end up choosing any interpreter, which is a bug.Result:
This also fixes an invalid type for
--ipython-ignore-cwd.[ci skip-rust]
[ci skip-build-wheels]