Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pex-binary/python-distribution to avoid naming collisions. #11007

Merged
merged 2 commits into from Oct 21, 2020
Merged

Rename pex-binary/python-distribution to avoid naming collisions. #11007

merged 2 commits into from Oct 21, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Oct 21, 2020

See #10999.

[ci skip-rust]

[ci skip-build-wheels]

@benjyw
Rename subsystems to avoid naming collisions.
76c3b7e 
See pantsbuild#10999.

[ci skip-rust]

[ci skip-build-wheels]
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Oct 21, 2020

cc @ZdenekM

Eric-Arellano
Eric-Arellano approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. A better changelog title might be "Rename pex-binary and python-distribution systems to avoid naming collisions"

@benjyw
Fix test
84c4963 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@benjyw benjyw changed the title Rename subsystems to avoid naming collisions. Rename pex-binary/python-distribution to avoid naming collisions. Oct 21, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 84c4963 on benjyw:rename_subsystems into 56b2562 on pantsbuild:master.

@benjyw benjyw merged commit 92a2087 into pantsbuild:master Oct 21, 2020
@benjyw benjyw deleted the rename_subsystems branch October 21, 2020 18:51
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Oct 21, 2020
@benjyw @Eric-Arellano
Rename pex-binary/python-distribution to avoid naming collisions. (pa…
51a8583 
…ntsbuild#11007)

See pantsbuild#10999.

[ci skip-rust]

[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this pull request Oct 21, 2020
@Eric-Arellano
Rename pex-binary/python-distribution to avoid naming collisions. (Ch…
bf72c65 
…erry-pick of #11007) (#11010)

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjyw @coveralls @Eric-Arellano