Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default [python-setup].resolver_jobs to cpu_count / 2 (Cherry-pick of #11006) #11011

Merged
merged 1 commit into from Oct 21, 2020

Conversation

Eric-Arellano
Copy link
Contributor

[ci skip-rust]
[ci skip-build-wheels]

…antsbuild#11006)

This option controls the concurrency of each Pex subprocess. 

We had set the default low to 2 because—before we added the single resolve optimization—it was common to build multiple PEXes at the same time. This resulted in exhaustion / an OOM issue for Toolchain, which was tricky to figure out.

Now, the user normally builds no more than 1-3 PEXes at a time, unless running `./pants package ::` or does not use a constraints file so we can't use a single resolve. So, our default is missing out on performance.

PEX's normal default is `cpu_count`. Instead, we use `cpu_count / 2` to try to balance performance vs. safety.

[ci skip-rust]
[ci skip-build-wheels]
@Eric-Arellano
Copy link
Contributor Author

Cherry-pick with no modifications.

Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eric-Arellano Eric-Arellano merged commit 441c58b into pantsbuild:2.0.x Oct 21, 2020
@Eric-Arellano Eric-Arellano deleted the cp-jobs branch October 21, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants