Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that option scopes and target aliases don't collide. (Cherry-pick of #11004) #11015

Merged
merged 1 commit into from Oct 22, 2020

Conversation

Eric-Arellano
Copy link
Contributor

[ci skip-rust]

…uild#11004)

Also reserves some names that cannot be used as scopes or aliases
('global', 'targets', 'goals') so that `./pants help <name>` is
unambiguous.

Works towards addressing pantsbuild#10999.

Also removes some cruft from test_extension_loader.py.
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick with no modifications.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling e604cc4 on Eric-Arellano:cp-validate into bf72c65 on pantsbuild:2.0.x.

Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eric-Arellano Eric-Arellano merged commit a6e1151 into pantsbuild:2.0.x Oct 22, 2020
@Eric-Arellano Eric-Arellano deleted the cp-validate branch October 22, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants